revert: back out ADR 0042's lineage reference routing (#191) #194
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "revert/adr-0042-lineage-reference"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Clean
git revert -m 1of the #191 merge. Staging showed the routing is empirically broken:style, onecharacter) is degenerate conditioning.character-type director entry on theinfillaction evidently makes the server disregard masked generation entirely.This restores yesterday's behavior at every tier: project style image as the style reference, ancestor sprite as the character reference under the likeness flag, expressions inpainting with style+character as before. The ADR 0042 document is removed with it — the decision is refuted as implemented.
Post-mortem, for the redo
The mapper only ever used
ReferenceType.Styleand.Characterat hardcoded 1.0/1.0. The library (and NAI's API) has aCharacterAndStyle("character&style") caption — a single director entry carrying both channels — which is the correct primitive for "one image, both channels" and was never used. The redo will be designed around:CharacterAndStyleentry for the outfit's base-sprite reference (never the same image as two entries),Suite green: 1,748 tests.
🤖 Generated with Claude Code
Summary
Summary
Coverage
Kagura.BlazorAdapter - 88.2%
Kagura.Domain - 96.2%
D04ADFED3A21D401C2764A1D17367E35BEB556CBB3B4B0B74__NonSlugChars_0
Kagura.Infrastructure - 97.8%
n
on
C689CA5BBE6D1849B2CA79581BBB07D40636D85790C0E51A9__ArtifactTimestampRegex_2
C689CA5BBE6D1849B2CA79581BBB07D40636D85790C0E51A9__ProjectRoute_0
C689CA5BBE6D1849B2CA79581BBB07D40636D85790C0E51A9__TabQuery_1
Kagura.Kernel - 90%
Kagura.Server - 83%
Kagura.UI - 94.9%
Kagura.UseCases - 95.9%