Expression infill prompt still reads the pre-0062 chain (no attribute bundle, no root tuning) #246

New issue

Closed

opened 2026-08-10 21:01:59 +02:00 by scarlet · 0 comments

scarlet commented

2026-08-10 21:01:59 +02:00

Member

Follow-up from PR #245 review (💡1). ExpressionImageGenerator still builds its prompt from outfit.EffectiveTags(character.BaseTags) — deliberately attribute-free under ADR 0038's "expressions inherit by construction". Since ADR 0062/0063, the outfit sprite it inpaints IS rendered with the (root-tuned) attribute bundle, so the expression's repeated prompt no longer matches the sprite's actual prompt — the original "repeating it keeps the inpainted face consistent" rationale now argues for outfit.EffectiveTags(character.AppearanceChain()) instead.

Decide whether the infill prompt should follow the chain (likely yes, for prompt/sprite consistency — the mask limits the effect to the face regardless) or stay attribute-free with the rationale rewritten. Either way the answer belongs in a small ADR-0062 amendment note.

🤖 Generated with Claude Code

Follow-up from PR #245 review (💡1). `ExpressionImageGenerator` still builds its prompt from `outfit.EffectiveTags(character.BaseTags)` — deliberately attribute-free under ADR 0038's "expressions inherit by construction". Since ADR 0062/0063, the outfit sprite it inpaints IS rendered with the (root-tuned) attribute bundle, so the expression's repeated prompt no longer matches the sprite's actual prompt — the original "repeating it keeps the inpainted face consistent" rationale now argues for `outfit.EffectiveTags(character.AppearanceChain())` instead. Decide whether the infill prompt should follow the chain (likely yes, for prompt/sprite consistency — the mask limits the effect to the face regardless) or stay attribute-free with the rationale rewritten. Either way the answer belongs in a small ADR-0062 amendment note. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

scarlet referenced this issue

2026-08-10 21:02:18 +02:00

feat(characters): the character is a tuning row too (ADR 0063) #245