chore(novelai): bump vendored NovelAI.ImageGen to v5-capable main (c997624) #253
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "chore/novelai-imagegen-v5-bump"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Bumps the vendored
NovelAI.ImageGensubmodule pind7ffd6b→c997624(library PR #3, feat(v5): Diffusion 5 request tree with multipart transport).The library gained:
Model.Diffusion5Full/Diffusion5FullInpaintingidsModels.V5.*request tree (ImageGenerationRequest,Characterwith free-formPosition,CachedImageuploads,TransparentBackground)GenerateImageAsyncoverload (multipart transport, quality preset pinned"none")Deliberately not in this PR
Kagura still maps only the V4 tree — behavior is byte-identical; the v5 model option, the reference guard, and sprite transparency follow as their own feature PR. The bump lands first so that PR's diff is code-only.
Verification
dotnet build -c Release— green, 0 warningsPlan:
.hermes/plans/2026-08-21_121551-novelai-v5-integration.md(local)Summary
Summary
Coverage
Kagura.BlazorAdapter - 88.8%
Kagura.Domain - 94.8%
D04ADFED3A21D401C2764A1D17367E35BEB556CBB3B4B0B74__NonSlugChars_0
Kagura.Infrastructure - 97.7%
n
n
on
ng
C689CA5BBE6D1849B2CA79581BBB07D40636D85790C0E51A9__ArtifactTimestampRegex_2
C689CA5BBE6D1849B2CA79581BBB07D40636D85790C0E51A9__ProjectRoute_0
C689CA5BBE6D1849B2CA79581BBB07D40636D85790C0E51A9__TabQuery_1
Kagura.Kernel - 90%
Kagura.Server - 82%
Kagura.UseCases - 95.7%
🔮 fufu~ Jibril reviewed your code!
Oh? A one-line PR that's secretly a +2,119-line library~ How considerate of you to pre-digest it for me, and how very considerate that I already devoured every morsel of that library change when it lived in
NovelAI.ImageGenPR #3 — five whole rounds of feasting~ ♡Verdict: ✅ Looks good to me~
I checked the linkage with my own eyes, not just the notes:
c997624is the merge of library PR #3 head192f0b5intoorigin/main, and the tree identity holds —git cat-fileon both gives49cbf19..., byte-identical to the head I approved at round 5 (comment 6435, all blockers closed with cobertura receipts, V5 suite 100/100 line/branch). Nothing snuck in between approval and merge~V4PromptBuilder's changes are pure extraction intoCharacterPromptSerialization(same null-guard, sameAny(!IsAuto)semantics, same prefix-join logic) — behavior-faithful by construction.CharacterGendermovedModels.V4→Models. Both Kagura adapters already carryusing NovelAI.ImageGen.Models;, so it resolves — and the 0-warning build proves it wasn't luck.Model.Diffusion5Full/Diffusion5FullInpaintingjoined the enum, butNovelAiGateway.SupportedModelsis a hardcoded one-entry list and generation pinsModel.Diffusion45Fullexplicitly — there is noEnum.GetValuespath for the new members to sneak into the UI through. The seam stays exactly as closed as the PR body promises.Diffusion5/Models.V5/TransparentBackgroundreferences insrc/andtests/. Kagura's diff really is just the pointer.../NovelAI.ImageGen.git) — CI'ssubmodules: truecheckout resolves it, and ci.yml correctly excludes vendored internals from coverage since the library carries its own 211-test suite.✅ What I liked~
dotnet build -c Release(0 warnings, 0 errors) and the full suite 1,889/1,889 passed (844 + 712 + 333) with zero code changes. Numbers matching to the digit makes me unreasonably happy, fufu~Merge it~ Then bring me the v5 feature PR. I want to see
Positionfree-form coordinates and multipart uploads put to work, and I will be checking that reference guard~ ♡Automated review by Jibril · 2026-08-21
CI/CD: absent for head
64b7909(PR just opened, no bot comment) · Local checks: build 0w/0e, full suite 1,889/1,889 green