fix(sheets): the three-view canvas stretches to 1216×832 (+64 wide, −64 tall) #271
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/three-view-canvas-wider"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The owner's live tuning after trying #270: three figures wanted more width and could give up height — +64 / −64.
One correction to the mooted numbers: 896 − 64 is 832, not 812 — and 812 wouldn't be a multiple of 64, which NovelAI's API requires of dimensions. So the canvas is 1216×832. Positions are normalized (0.25/0.5/0.75) and ride unchanged.
Touched: the
ThreeViewSheetconstant, its doc, both integration pin sites, and ADR 0066's amendment text — five occurrences across four files, all updated together.Full suite: integration 786/786, usecases 340/340, blazoradapter 870/870.
Summary
Summary
Coverage
Kagura.BlazorAdapter - 89%
Kagura.Domain - 94.8%
D04ADFED3A21D401C2764A1D17367E35BEB556CBB3B4B0B74__NonSlugChars_0
Kagura.Infrastructure - 97.7%
n
n
on
ng
C689CA5BBE6D1849B2CA79581BBB07D40636D85790C0E51A9__ArtifactTimestampRegex_2
C689CA5BBE6D1849B2CA79581BBB07D40636D85790C0E51A9__ProjectRoute_0
C689CA5BBE6D1849B2CA79581BBB07D40636D85790C0E51A9__TabQuery_1
Kagura.Kernel - 90%
Kagura.Server - 81.5%
Kagura.UseCases - 95.5%
🔮 fufu~ Jibril reviewed your code!
Oh? Oh my~ The owner traced a live tuning session straight into a five-line prayer of a diff, and every single candle is lit where it should be. +64 wide, −64 tall, and nothing else moves. This is what a retune PR dreams of being~ ♪
Verdict: ✅ Looks good to me~
What I verified, line by line:
ThreeViewSheetconstant (SpriteGeneration.cs:31), its doc comment, both integration pin sites (the 3-arm gender theory inCharacterImageGenerationTestsand the outfit-sheet pin inOutfitImageGenerationTests), and ADR 0066's amendment text. And a tree-wide sweep for1152/896returns zero stragglers — not in docs, not in comments, not anywhere. The sweep pleases me~ ♡Granularityguard would have thrown otherwise), and 1216×832 is no stranger to this codebase: it's the provenLandscapecanvas shipping on every event CG. The API has swallowed this exact size a hundred times. No smoke-test anxiety here~1152×896→ exactly the 4 back-view tests go RED (Actual: 1152at the width assert); restored → 4/4 green, tree pristine. Not a tautology among them~ ♡Local checks (CI absent for head
0f079c7, so I ran everything myself): build 0 warnings / 0 errors, and the suites match the body's numbers exactly — integration 786/786, usecases 340/340, blazoradapter 870/870.💡 Little ideas (non-blocking)~
CharacterBaseSprite.razor:16/OutfitSheet.razor:19,24— the preview boxes still declareRatio="1088 / 960", so a three-view sheet center-crops slightly in the small preview until clicked open. Purely cosmetic, pre-existing from #270 (the legacy 832×1216 transition note documents the same accepted behavior), and the flag is experimental — but if the retune graduates, the preview ratio is the loose thread to pull. Not this PR's job~✅ What I liked~
GenerationCanvas.ThreeViewSheetexactly as ADR 0066 architected it; tests pin the values independently, so the pin and the constant aren't holding hands in a tautology loopFufu~ a retune so clean I almost didn't get to sharpen anything. Almost~ ♡
Automated review by Jibril · 2026-09-04
CI/CD: absent for head SHA
0f079c7· Local checks: build 0/0 · 786/786 · 340/340 · 870/870 · mutation probe RED→green