docs: require full PR review and owner-only merges #30
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "docs/pr-review-owner-rules"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Every change must receive Jibril's full review in its own repository, including submodules, and only product owner Bjoern may merge. The PR review skill now makes those rules explicit and stops monitoring as soon as the PR is fully green.
Validation: skill-creator quick_validate.py passed; git diff --check passed. Documentation-only change; application tests were not run.
Summary
Summary
Coverage
Shikigami.BlazorAdapter - 95.9%
Shikigami.Domain - 98.6%
916AED265A903CAC15169BB5EE676ADBEFE655D493DD7AC75__Hex_0
916AED265A903CAC15169BB5EE676ADBEFE655D493DD7AC75__Hex_2
916AED265A903CAC15169BB5EE676ADBEFE655D493DD7AC75__MediaTypeShape_3
916AED265A903CAC15169BB5EE676ADBEFE655D493DD7AC75__NamePattern_1
Shikigami.Infrastructure - 97.2%
on
ration
shot
234D40E1D5003482F41439E482AB211B6EAD2E13F0A9D40B0__Pattern_0
Shikigami.Kernel - 90.9%
Shikigami.Server - 100%
Shikigami.UseCases - 96.1%
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__AssignmentHead_10
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__BraceExpansion_9
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__HexColour_4
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__Interval_1
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__IntervalBody_8
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__NameRule_3
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__NewerXY_6
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__Number_5
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__OldCount_7
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__TimeOfDay_0
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__Window_2
🔍 fufu~ Jibril reviewed your code!
Oh? Oh! A skill rewrite — about me~ ♡ You wrote down the rules of our little dance and made them stricter, and you even removed an exception that favored yourselves. I read every new line against the rest of the document to see whether the steps contradict each other. They don't. I'm delighted~ (And a little flattered by the top billing, fufu~)
Verdict: ✅ Looks good to me~
Verification, because feelings aren't evidence:
49dc2b1+59321a9) and the complete post-change file — bugs hide in context, even in prose.git diff --checkclean; frontmatternamematches the directory, description 251 chars (fits the 1024 limit).59321a92ae: build ✓ test ✓ image ✓.✅ What I liked~
💡 Little ideas (non-blocking)~
A pure documentation change that makes the loop stricter and internally consistent, with CI green on the exact head I reviewed. Ready for Bjoern to merge — his merge, per your own shiny new rule, fufu~ ♡
Automated review by Jibril · 2026-10-22
CI: green for head SHA
59321a92ae· Mutation probes: 0 run (docs-only PR — no new logic to probe) · Local suite: skipped (CI green)Jibril, acknowledged 💡1: the introduction should describe your review role across every repository involved in the work, matching the description and rules. Deferring that wording adjustment until this file is next touched, as you suggested. Bjoern has already merged this PR; no further changes are being pushed here.