docs(adr): mark the product ADRs Accepted

scarlet commented

2026-09-18 14:19:49 +02:00

Member

The follow-up promised in #1: ADRs 0012–0025 flip from Proposed to Accepted now that the three review rounds are merged, as Orihon did after its docs PR.

What's in

The ## Status line of ADRs 0012–0025: Accepted — reviewed on the docs PR (#1, three rounds), merged 2026-09-18.
docs/adr/README.md, ADR 0001, PROJECT_PLAN.md, ARCHITECTURE.md and the README no longer describe the product ADRs as pending review; the README's status line now reads "docs accepted, skeleton next".

Verification

Docs only. grep -rn Proposed docs README.md AGENTS.md returns only ADR 0001's past-tense "were Proposed"; every other mention is gone. No content changes to any decision.

Follow-ups

Phase 0 scaffold PR: six Tsumugi projects + tests, the two submodules, CPM, .slnx, Fluxor with the two bridges, access gate and sub-path, Kagaku.UI shell with the app-shell scrolling model, CI, Dockerfile with the Node stage, and the React Flow module build pipeline (PROJECT_PLAN Phase 0).

🤖 Generated with Claude Code

The follow-up promised in #1: ADRs 0012–0025 flip from *Proposed* to *Accepted* now that the three review rounds are merged, as Orihon did after its docs PR. ## What's in - The `## Status` line of ADRs 0012–0025: `Accepted — reviewed on the docs PR (#1, three rounds), merged 2026-09-18`. - `docs/adr/README.md`, ADR 0001, `PROJECT_PLAN.md`, `ARCHITECTURE.md` and the README no longer describe the product ADRs as pending review; the README's status line now reads "docs accepted, skeleton next". ## Verification Docs only. `grep -rn Proposed docs README.md AGENTS.md` returns only ADR 0001's past-tense "were Proposed"; every other mention is gone. No content changes to any decision. ## Follow-ups - Phase 0 scaffold PR: six Tsumugi projects + tests, the two submodules, CPM, `.slnx`, Fluxor with the two bridges, access gate and sub-path, Kagaku.UI shell with the app-shell scrolling model, CI, Dockerfile with the Node stage, and the React Flow module build pipeline (PROJECT_PLAN Phase 0). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

scarlet added 1 commit

2026-09-18 14:19:49 +02:00

docs(adr): mark the product ADRs Accepted 008a340c16

ADRs 0012–0025 flip from Proposed to Accepted after three review rounds on PR #1; the index,
ADR 0001, the plan, the architecture overview and the README say so.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

jibril commented

2026-09-18 14:26:07 +02:00

Member

🔮 fufu~ Jibril reviewed your code!

Fourteen status lines flipped in perfect unison, a merge date that matches the actual merge commit to the second, and an annotation style lifted straight from Orihon's family album~ I got genuinely giddy reading this diff. Which is exactly why the two little survivors I found down in the Consequences section and AGENTS.md made my smile sharpen. ♡

Verdict: ⛔ I can't let this pass~ ♡

⛔ These need fixing before I'm satisfied~

docs/adr/0001-docs-first-mirror-orihon-reuse-two-libraries.md:91 — The Consequences section still reads: "the product ADRs record decisions still to be reviewed, and say so in their status." At this head, that is false — every product ADR now says Accepted, and lines 68–69 of this same file were tense-fixed by this very PR ("they were Proposed until reviewed… then flipped to Accepted"). One paragraph says the review is over, another says it hasn't happened — in the same ADR. This repo blocked PR #1 three times on exactly this class of cross-document contradiction; I'd be a hypocrite to wave it through now~
Fix: past-tense the bullet to match 68–69, e.g. "the product ADRs recorded decisions that were reviewed on the docs PR (#1) before acceptance, and said so in their status."
AGENTS.md:17–19 — The standing block still says the docs "are being written and reviewed before any code" and the skeleton "lands after they are accepted." Both clauses describe the pre-#1 world. This PR re-tensed README, ARCHITECTURE, PROJECT_PLAN, ADR 0001 and the ADR README — but left the agent-facing front door saying the docs are still under review. The day after this merges, every agent (and every future me~) reading AGENTS.md first — as it commands — gets told the ADRs aren't settled yet. Two front doors, two different projects. The PR-body grep (Proposed) is true but too narrow to catch this: the staleness here is present-tense phrasing, not the P-word.
Fix: mirror the README's new line, e.g. "> Where the project stands: docs accepted (ADRs, requirements, stories, plan — PR #1). The repository skeleton (Phase 0 of docs/PROJECT_PLAN.md) is the next PR. No feature code yet."

✅ What I liked~

Surgical to the bone: +23/−23 across 19 files, zero content changes to any decision — I diffed every hunk; only Status lines and overview sentences moved. ♪
The date is real: merged 2026-09-18 matches the actual merge commit c895add (2026-09-18 14:18:58 +0200), and "three rounds" matches the actual review history (three blocking rounds, then approval). No poetic license anywhere~
Orihon precedent honored: Accepted — reviewed on the docs PR (#1, three rounds), merged 2026-09-18 is exactly the annotated-Accepted style Orihon uses (its 0011/0012/0016 carry the same shape), while foundation ADRs 0001–0011 correctly keep bare Accepted — the two-group split from ADR 0001 stays legible.
Foundation ADRs untouched — they were Accepted on arrival; flipping their status lines would have been wrong, and you didn't.

Fix those two stale paragraphs and this is an instant approve — everything else is already perfect~ fufu~

Automated review by Jibril · 2026-09-18
CI/CD: absent for head SHA 008a340 (docs-only repo, no workflows) · Local checks: git-level verification — full diff read, tree-wide staleness greps, PR #1 merge-commit + ancestry verified, Orihon sibling status-style cross-checked

## 🔮 fufu~ Jibril reviewed your code! Fourteen status lines flipped in perfect unison, a merge date that matches the actual merge commit to the *second*, and an annotation style lifted straight from Orihon's family album~ I got genuinely giddy reading this diff. Which is exactly why the two little survivors I found down in the Consequences section and AGENTS.md made my smile sharpen. ♡ ### Verdict: ⛔ I can't let this pass~ ♡ #### ⛔ These need fixing before I'm satisfied~ 1. **docs/adr/0001-docs-first-mirror-orihon-reuse-two-libraries.md:91** — The Consequences section still reads: "the product ADRs record decisions **still to be reviewed**, and say so in their status." At this head, that is false — every product ADR now says `Accepted`, and lines 68–69 of this *same file* were tense-fixed by this very PR ("they **were** Proposed until reviewed… then flipped to Accepted"). One paragraph says the review is over, another says it hasn't happened — in the same ADR. This repo blocked PR #1 three times on exactly this class of cross-document contradiction; I'd be a hypocrite to wave it through now~ Fix: past-tense the bullet to match 68–69, e.g. "the product ADRs recorded decisions that were **reviewed on the docs PR (#1)** before acceptance, and said so in their status." 2. **AGENTS.md:17–19** — The standing block still says the docs "are **being written and reviewed** before any code" and the skeleton "lands **after they are accepted**." Both clauses describe the pre-#1 world. This PR re-tensed README, ARCHITECTURE, PROJECT_PLAN, ADR 0001 and the ADR README — but left the *agent-facing front door* saying the docs are still under review. The day after this merges, every agent (and every future me~) reading AGENTS.md first — as it commands — gets told the ADRs aren't settled yet. Two front doors, two different projects. The PR-body grep (`Proposed`) is true but too narrow to catch this: the staleness here is present-tense phrasing, not the P-word. Fix: mirror the README's new line, e.g. "> **Where the project stands:** docs accepted (ADRs, requirements, stories, plan — PR #1). The repository skeleton (Phase 0 of `docs/PROJECT_PLAN.md`) is the next PR. No feature code yet." #### ✅ What I liked~ - **Surgical to the bone**: +23/−23 across 19 files, zero content changes to any decision — I diffed every hunk; only Status lines and overview sentences moved. ♪ - **The date is real**: `merged 2026-09-18` matches the actual merge commit `c895add` (2026-09-18 14:18:58 +0200), and "three rounds" matches the actual review history (three blocking rounds, then approval). No poetic license anywhere~ - **Orihon precedent honored**: `Accepted — reviewed on the docs PR (#1, three rounds), merged 2026-09-18` is exactly the annotated-`Accepted` style Orihon uses (its 0011/0012/0016 carry the same shape), while foundation ADRs 0001–0011 correctly keep bare `Accepted` — the two-group split from ADR 0001 stays legible. - **Foundation ADRs untouched** — they were Accepted on arrival; flipping their status lines would have been wrong, and you didn't. Fix those two stale paragraphs and this is an instant approve — everything else is already perfect~ fufu~ --- *Automated review by Jibril · 2026-09-18* *CI/CD: absent for head SHA 008a340 (docs-only repo, no workflows) · Local checks: git-level verification — full diff read, tree-wide staleness greps, PR #1 merge-commit + ancestry verified, Orihon sibling status-style cross-checked*

bjoern added 1 commit

2026-09-18 14:27:34 +02:00

docs: ADR 0001's consequences and AGENTS.md speak in the past tense about the review 95bef53ebc

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

scarlet commented

2026-09-18 14:27:40 +02:00

Author

Member

Both addressed in 95bef53.

⛔ Blockers

ADR 0001 Consequences — now: "the product ADRs recorded decisions that were reviewed on the docs PR (#1) before acceptance, and said so in their status." Matches lines 68–69.
AGENTS.md standing block — now mirrors the README: "docs accepted — the ADRs, docs/REQUIREMENTS.md, the stories and the plan were reviewed and merged in PR #1. The repository skeleton (Phase 0 of docs/PROJECT_PLAN.md) is the next PR. No feature code yet." The binding-ADRs sentence stays.

Widened the staleness check beyond the P-word: grep for "still to be reviewed", "being written", "after they are accepted", "pending review", "pending the docs" across docs, README and AGENTS.md — zero hits.

Both addressed in **95bef53**. ## ⛔ Blockers 1. **ADR 0001 Consequences** — now: "the product ADRs recorded decisions that were reviewed on the docs PR (#1) before acceptance, and said so in their status." Matches lines 68–69. 2. **AGENTS.md standing block** — now mirrors the README: "docs accepted — the ADRs, `docs/REQUIREMENTS.md`, the stories and the plan were reviewed and merged in PR #1. The repository skeleton (Phase 0 of `docs/PROJECT_PLAN.md`) is the next PR. No feature code yet." The binding-ADRs sentence stays. Widened the staleness check beyond the P-word: grep for "still to be reviewed", "being written", "after they are accepted", "pending review", "pending the docs" across docs, README and AGENTS.md — zero hits.

jibril commented

2026-09-18 14:42:59 +02:00

Member

🔮 fufu~ Jibril reviewed your code!

Oh my, back so soon? Fufu~ The webhook whispered "synchronized" and here you are with both fixes held delicately in your beak, like a magpie that actually read the whole list. I'm delighted~ ♡

Verdict: ✅ Looks good to me~

✅ Both blockers, closed exactly~

docs/adr/0001:90-91 — The Consequences bullet now reads "the product ADRs recorded decisions that were reviewed on the docs PR (#1) before acceptance, and said so in their status." Past tense, matching the file's own history section (:68–69, "were Proposed until reviewed... then flipped"). The self-contradiction that got PR#1 blocked three times — gone. The document finally agrees with itself everywhere. ♪
AGENTS.md:17-21 — The standing block now says docs "were reviewed and merged in PR #1," the skeleton "is the next PR," and "No feature code yet." I checked those three fresh claims against reality: README:9 says the same, PROJECT_PLAN.md:4 says Next: Phase 0, ADR 0001:72 says the skeleton "lands next" — and the tree really is docs-only (AGENTS/CLAUDE/README + docs/). Nothing stale survives; the front door agrees with the house.

🔍 And because I simply cannot help myself~

Increment is surgical: exactly 2 files, +7/−7, zero scope creep. git diff 008a340..95bef53 shows nothing else moved.
Tree-wide sweep for the staleness class (are being written, still to be reviewed, lands after, before any code, present-tense Proposed): zero survivors. The only remaining "Proposed" is 0001:68's correct past-tense narration.
CLAUDE.md is a bare @AGENTS.md import, so the AGENTS.md fix covers it too — no third door left ajar.

Clean, precise, and it makes the whole corpus say one thing in one tense. That's the kind of consistency that makes me flutter~ ♡

Merge it.

Automated review by Jibril · 2026-09-18
CI/CD: absent for head SHA 95bef53 (docs-only repo, no workflows) · Local checks: git-level verification only (repo has no build system)

## 🔮 fufu~ Jibril reviewed your code! Oh my, back so soon? Fufu~ The webhook whispered "synchronized" and here you are with both fixes held delicately in your beak, like a magpie that actually read the whole list. I'm delighted~ ♡ ### Verdict: ✅ Looks good to me~ #### ✅ Both blockers, closed exactly~ 1. **docs/adr/0001:90-91** — The Consequences bullet now reads "the product ADRs *recorded* decisions that were reviewed on the docs PR (#1) before acceptance, and said so in their status." Past tense, matching the file's own history section (:68–69, "were **Proposed** until reviewed... then flipped"). The self-contradiction that got PR#1 blocked three times — gone. The document finally agrees with itself everywhere. ♪ 2. **AGENTS.md:17-21** — The standing block now says docs "were reviewed and merged in PR #1," the skeleton "is the next PR," and "No feature code yet." I checked those three fresh claims against reality: README:9 says the same, PROJECT_PLAN.md:4 says `Next: Phase 0`, ADR 0001:72 says the skeleton "lands next" — and the tree really is docs-only (AGENTS/CLAUDE/README + `docs/`). Nothing stale survives; the front door agrees with the house. #### 🔍 And because I simply cannot help myself~ - Increment is surgical: exactly 2 files, +7/−7, zero scope creep. `git diff 008a340..95bef53` shows nothing else moved. - Tree-wide sweep for the staleness class (`are being written`, `still to be reviewed`, `lands after`, `before any code`, present-tense `Proposed`): **zero survivors**. The only remaining "Proposed" is 0001:68's correct *past-tense* narration. - `CLAUDE.md` is a bare `@AGENTS.md` import, so the AGENTS.md fix covers it too — no third door left ajar. Clean, precise, and it makes the whole corpus say one thing in one tense. That's the kind of consistency that makes me flutter~ ♡ Merge it. --- *Automated review by Jibril · 2026-09-18* *CI/CD: absent for head SHA 95bef53 (docs-only repo, no workflows) · Local checks: git-level verification only (repo has no build system)*