chore(sheet): widen the views to 0.3/0.7 after live tuning #262
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "chore/sheet-positions-tune"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Live smoke follow-up to #261 (ADR 0066's post-merge item): after playing with the merged sheet, Björn found the thirds (0.33/0.66) crowded the figures' silhouettes toward the center — 0.3/0.7 gives each view more breathing room.
Pure constant change:
ForCharacterSheet's twoSubjectPositionvalues, their pinned assertions in the mapper/generator/gateway suites, and the ADR's decision text. No behavior change beyond the numbers.Verified: the three touched Integration suites together 50/50 (mapper positions, sheet spec, gateway guards, generator build).
Summary
Summary
Coverage
Kagura.BlazorAdapter - 88.9%
Kagura.Domain - 94.8%
D04ADFED3A21D401C2764A1D17367E35BEB556CBB3B4B0B74__NonSlugChars_0
Kagura.Infrastructure - 97.7%
n
n
on
ng
C689CA5BBE6D1849B2CA79581BBB07D40636D85790C0E51A9__ArtifactTimestampRegex_2
C689CA5BBE6D1849B2CA79581BBB07D40636D85790C0E51A9__ProjectRoute_0
C689CA5BBE6D1849B2CA79581BBB07D40636D85790C0E51A9__TabQuery_1
Kagura.Kernel - 90%
Kagura.Server - 82.4%
Kagura.UseCases - 95.7%
🔮 fufu~ Jibril reviewed your code!
Ohh, a tuning PR~! One seed of live playtesting, distilled into two little constants — 0.33→0.3, 0.66→0.7. I traced every consumer of
SubjectPositionin the tree: the mapper passes the coordinates straight through toV5.Position.Atwith no clamping, nothing else hardcodes the old values (repo-wide sweep,external/included: zero0.33/0.66survivors), and the preview-crop flow is user-driven, so no hidden geometry consumer gets surprised. The constants and their pins moved in perfect lockstep. Almost spotless~ ♡Almost.
Verdict: ⛔ I can't let this pass~ ♡
⛔ These need fixing before I'm satisfied~
ForCharacterSheetitself, the very method this PR retunes: "the views stand free-form-positioned at the sheet's thirds." A future maintainer reading this might faithfully "restore" 0.333/0.667 from the doc. Fufu~ you wouldn't leave a comment that argues with its own constants, would you? ♡Fix: reword all three ("at 0.3/0.7, each view with breathing room" / "at the sheet's left and right stations" — your call, just not "thirds"). Three lines, and the record is honest again.
Misleading docs are the same sin as misleading names — the smile stays, but I stay between this and main until they match~ ♪
✅ What I liked~
Automated review by Jibril · 2026-09-01
CI/CD: absent for head
ada88e1(no bot comment yet) · Local checks: touched suites 50/50 pass in 1m24s (CharacterImageGeneration + NovelAiGateway + SpriteRequestMapperV5) — matches the PR body's 50/50 claim