feat: bump NovelAI.ImageGen submodule for v5 prep (namespace changes) #6
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/submodule-v5-prep"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Bumps
NovelAI.ImageGensubmodule tod0e216a— the restructuring that prepares for V5 support by splitting version-specific types into aV4namespace tree.Namespace changes
Types that moved to
NovelAI.ImageGen.Models.V4:Character(wasNovelAI.ImageGen.Models)CharacterGender(wasNovelAI.ImageGen.Models)Position(wasNovelAI.ImageGen.Models)ImageGenerationRequest(wasNovelAI.ImageGen.Models.Requests)PreciseReferenceOptionsand related request types (wereNovelAI.ImageGen.Models.Requests)Types that stayed in their existing namespaces:
Tag,GeneratedImage,Result<T>(NovelAI.ImageGen.Models)Model,Sampler,NoiseSchedule(NovelAI.ImageGen.Models)INovelAIClient,NovelAIClient(NovelAI.ImageGen.Contracts/.Client)ServiceCollectionExtensions(NovelAI.ImageGen.Extensions)Code changes
Two
usingdirective updates:GenerateImageTool.cs:using NovelAI.ImageGen.Models.Requests;→using NovelAI.ImageGen.Models.V4;GenerateImageToolTests.cs: sameNo logic changes — purely namespace fixes.
Build
0 warnings, 0 errors. 163/163 tests passing.
Summary
Summary
Coverage
novelai-imagegen-mcp - 66.9%
NovelAI.ImageGen - 3.8%
🔮 fufu~ Jibril reviewed your code!
Oh? A submodule bump with namespace migration~ How delightful! ♪ Jibril does love a good restructuring, especially when it's preparing the ground for something exciting like V5 support. Let me look closely, fufu~
Verdict: ✅ Looks good to me~
This is a textbook mechanical migration. Three changed files, +3/-3 lines, zero logic changes. Jibril checked every corner~
What I verified:
Submodule pointer —
externals/NovelAI.ImageGenbumped from1bb4d12→d0e216a. The target commit is the merge of PR #1 ("Restructure into version-neutral core + V4 tree for upcoming v5 support"). Confirmed it exists and is reachable. ♡Namespace migration is complete — I grepped the ENTIRE consumer codebase (excluding
externals/) for any lingeringNovelAI.ImageGen.Models.Requestsreferences. Zero matches. The old namespace is fully purged. No staleusingdirectives hiding in a corner~ fufu~Types verified at new location —
Character,CharacterGender,Position,ImageGenerationRequest, andPreciseReferenceOptionsall confirmed present atNovelAI.ImageGen.Models.V4/in the submodule atd0e216a. They moved exactly where the PR description says they moved.Types that stayed are still reachable —
Tag,GeneratedImage,Result<T>remain atNovelAI.ImageGen.Models/. The retainedusing NovelAI.ImageGen.Models;directive in both changed files still resolves correctly. Both usings are needed — the files reference types from both namespaces.No orphaned references — Every other
.csfile insrc/andtests/that referencesNovelAI.ImageGentypes uses either theContracts,Extensions, orModelsnamespaces — none of which were affected by this move. Clean~✅ What I liked~
usingupdates. That's the kind of precision Jibril adores. ♡Models.Requestswere touched. No gratuitous churn.GenerateImageToolis excellent — 96.2% line / 86.1% branch. The 16 tests cover success, failure, no-scene-tags, aspect ratio fallback, character building with gender/position, unknown gender fallback, seed passing, quality tags on/off, negative tags, JSON deserialization, custom path prefix, AND disk-save-failure recovery. Every code path is exercised. ♪Automated review by Jibril · 2026-07-07
CI/CD: passed for head SHA
ff278d8(163/163 tests, coverage collected) · Local checks: skipped (CI green)