chore: adopt Kagaku.UI context inspection primitives #52
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/context-inspector-primitives"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Adopt Kagaku.UI's context-inspection primitives and complete the library-track entry in the project plan (ADR 0004, 0009 and 0023). Shikigami can now build its context inspector from selectable usage bars, linked legends and highlighted content sections.
The submodule points to the actual upstream
maincommit after the library PR, whose tree matches the reviewed candidate. The pointer also includes the previously reviewed Drawer, ChatMessage and Toast additions. Application-aware inspection and prompt/cache policy remain in the later application slices.Validation:
TZ=UTC.The library PR contains the actual standalone sample screenshots and browser evidence. This companion changes the pointer and plan only; no new familiar state or application UI is introduced, so the existing seed remains sufficient.
Summary
Summary
Coverage
Shikigami.BlazorAdapter - 95.3%
Shikigami.Capabilities.Contracts - 100%
Shikigami.Capabilities.TestFixture - 95.5%
Shikigami.Capabilities.TestFixture.UI - 100%
Shikigami.Capabilities.UI.Contracts - 91.3%
Shikigami.Domain - 98.1%
916AED265A903CAC15169BB5EE676ADBEFE655D493DD7AC75__Hex_0
916AED265A903CAC15169BB5EE676ADBEFE655D493DD7AC75__Hex_2
916AED265A903CAC15169BB5EE676ADBEFE655D493DD7AC75__MediaTypeShape_3
916AED265A903CAC15169BB5EE676ADBEFE655D493DD7AC75__NamePattern_1
Shikigami.Infrastructure - 93.7%
Mapping
ping
apping
on
ration
ts
shot
234D40E1D5003482F41439E482AB211B6EAD2E13F0A9D40B0__Id_1
234D40E1D5003482F41439E482AB211B6EAD2E13F0A9D40B0__Pattern_0
Shikigami.Kernel - 90.9%
Shikigami.Server - 84.4%
Shikigami.UseCases - 96.2%
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__AssignmentHead_13
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__BraceExpansion_12
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__HexColour_7
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__IdPattern_0
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__Interval_4
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__IntervalBody_11
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__KeyPattern_2
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__NameRule_6
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__NewerXY_9
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__Number_8
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__OldCount_10
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__TimeOfDay_3
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__ToolPattern_1
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__Window_5
🔮 fufu~ Jibril reviewed your code!
A pointer bump and a plan entry — only nine lines, but a pointer that lies would poison everything downstream, so I held every claim under my magnifying glass~ And oh, oh! Every single one survived. That rarely happens. ♡
Verdict: ✅ Looks good to me~
What I verified mechanically, not by trusting the description:
c35aac06is the current head of upstreamKagaku.UImain — and its commit message is merged PR #51 with theReviewed-on:footer, committed by bjoern (owner merge). Not a stray branch tip, not a force-push orphan.merge-base --is-ancestorin the actual submodule confirms95a63bb(#47) → #48 Drawer → #49 ChatMessage → #50 Toast →c35aac06(#51). Nothing skipped, no history rewrite — exactly the "includes the previously reviewed Drawer, ChatMessage and Toast additions" the PR body promises.InspectionSection.razor+.css,UsageBar.razor, and the newUsageBarSelectionTests/UsageBarBehaviorTestsare all present at the new pointer. The plan entry describes what actually shipped.Kagaku.UI.InspectionDemosample project is harmless here.deploy/Dockerfilerestores onlyShikigami.Server.csprojand never copies the library.slnxorsamples/, so the demo project never enters the Server's restore graph.**Title.** ✅ …shape as the surrounding entries, ADR 0009/0023 kept, and both deferred destinations exist: 2d "The prompt" (inspector) and 2h "Context and the cache" (prompt/cache policy). The library stayed policy-free, exactly as ADR 0009 demands. ♪⚠️ Not this PR's fault — but someone must look, please~
CI / imageis red on this head — but it is equally red onmainat this PR's own merge base:a1be9bf(before C2d #50): image green, docker-publish green117f619e(= merge base, C2d #50 merged): image red — fails in Build the image (~1m28s), the two follow-up steps never ran8224789e(this PR): the same failure, same step, ~1m20s — whilebuild,test(with coverage) andshell-evalare all greenSo the regression rode in with the C2d merge window, not with this pointer bump — this diff touches no project graph, no Dockerfile, no props. The job logs need a signed-in session, so I cannot see the failing line; I name no root cause beyond that window. But the image job exists precisely as the pre-merge gate ("a new project or reference adds its line here — CI's image job fails until it does"), and main's gate is standing open right now. Fix it on main, darlings~ Also note
Build and Push Docker Imagehas been sitting pending on main since that same push — possibly the same cause, possibly a queued runner.Merging this PR neither causes nor worsens that — which is why I'm not blocking on it. But I will be watching main turn green again~ fufu~ ♡
✅ What I liked~
Automated review by Jibril · 2026-10-23
CI: build/test/shell-eval green for head SHA; image red — pre-existing on main (appeared with the C2d #50 push), identical at merge base · Mutation probes: 0 — no new executable code in this repo (gitlink + docs only; library PR #51 carried its own 17-mutation adversarial review) · Local suite: skipped (CI test job green for head)