docs: make semantic browser command portable #63
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "docs/portable-semantic-browser-command"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Remove the machine-specific Chrome path from the semantic browser example, addressing Jibril's portability note on the B2 consumer change. The command now uses the Playwright-installed Chromium from the existing setup instructions; the generic
CHROMIUM_EXECUTABLE_PATHguidance still explains how to select another installed browser.One documentation line changes. Independent adversarial review approved the complete diff and surrounding setup against the actual runner;
git diff --checkandnode --check tests/Browser/semantic-palette.cjspass. No executable code, fixtures, palette, screenshots or submodule pins change, so local build/browser/mutation runs were not repeated. The prior B2 suite and browser evidence remain applicable; this PR still requires its own CI and Jibril review.Summary
Summary
Coverage
Shikigami.BlazorAdapter - 95.4%
Shikigami.Capabilities.Contracts - 100%
Shikigami.Capabilities.TestFixture - 95.5%
Shikigami.Capabilities.TestFixture.UI - 100%
Shikigami.Capabilities.UI.Contracts - 91.3%
Shikigami.Capabilities.Web - 97.1%
Shikigami.Domain - 98.1%
916AED265A903CAC15169BB5EE676ADBEFE655D493DD7AC75__Hex_0
916AED265A903CAC15169BB5EE676ADBEFE655D493DD7AC75__Hex_2
916AED265A903CAC15169BB5EE676ADBEFE655D493DD7AC75__MediaTypeShape_3
916AED265A903CAC15169BB5EE676ADBEFE655D493DD7AC75__NamePattern_1
Shikigami.Infrastructure - 93.7%
Mapping
ping
apping
on
ration
ts
shot
234D40E1D5003482F41439E482AB211B6EAD2E13F0A9D40B0__Id_1
234D40E1D5003482F41439E482AB211B6EAD2E13F0A9D40B0__Pattern_0
Shikigami.Kernel - 90.9%
Shikigami.Server - 85.5%
Shikigami.UseCases - 96.1%
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__AssignmentHead_13
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__BraceExpansion_12
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__HexColour_7
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__IdPattern_0
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__Interval_4
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__IntervalBody_11
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__KeyPattern_2
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__NameRule_6
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__NewerXY_9
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__Number_8
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__OldCount_10
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__TimeOfDay_3
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__ToolPattern_1
F24B88780DF6A41103E39D76537F056A9F694C6955C8C8CF6__Window_5
🔮 fufu~ Jibril reviewed your code!
Oh? A one-line PR that does exactly what it says? How delightfully rare~ ♡ You removed the machine-specific
/usr/bin/google-chromefrom the semantic-palette example — my portability note on #62, answered precisely. I couldn't resist tracing the whole path before smiling, of course.Verdict: ✅ Looks good to me~
I verified the change from every angle I could sink my teeth into:
tests/Browser/README.md:62) now has the exact same bareNODE_PATH=… node tests/Browser/<x>.cjs …shape as the scaffold example (line 19) and theme example (line 41) in the same README. Three siblings, one form. Fufu~ that's the consistency I'm possessive about~semantic-palette.cjs:17–18only spreads inexecutablePathwhenCHROMIUM_EXECUTABLE_PATHis set (byte-identical pattern toscaffold.cjs:9andtheme.cjs:9), so without the variable Playwright resolves its own registry browser — which the setup block (README lines 17–18:npm install --prefix /tmp/kagaku-browser-tools … playwright+playwright install chromium) installs. Follow setup, run command, get Chromium. No machine-specific assumptions left anywhere.CHROMIUM_EXECUTABLE_PATHfor using an installed browser instead of downloading, exactly as the PR description claims./usr/bin/google-chromehardcodes; every otherCHROMIUM_EXECUTABLE_PATHmention is generic guidance or the same env-conditional launch pattern.✅ What I liked~
No mutation probes this time — the only changed line is prose, and I don't mutate what I can't compile~ Be seeing you in the next diff ♡
Automated review by Jibril · 2026-10-23
CI: green for
08456513(build, image, shell-eval, test) · Mutation probes: 0 run — docs-only diff, no changed logic to probe · Local suite: skipped (CI green)