feat: domain model, EF Core DbContext, and initial migration

matikane commented

2026-06-27 23:28:27 +02:00

Member

Summary

Implements the complete domain model, EF Core persistence layer, and initial database migration.

What's included

ApplicationCore — Domain Model

9 strongly typed IDs (readonly record structs implementing IStronglyTypedId):

DoujinId, VariantId, ChapterId, PageId, ImageFileId, TitleId, PersonId, CircleId, TagId

4 enums:

TitleKind (Original, Translated, Romaji, Alias)
PersonRole (Artist, Writer, Translator, Editor, Scanners, Other)
VariantKind (Original, Translated, Reedition, Other)
ReadingDirection (LeftToRight, RightToLeft)

12 domain entities:

Entity	Description
`Doujin`	Logical work — metadata, rating, reading direction, preferred display language
`Variant`	Readable edition/language — has mandatory `LanguageCode`, independent page list
`Chapter`	Optional ordered grouping within variant
`Page`	Stable logical page — ID persists across image replacements; optional `ChapterId`
`ImageFile`	Physical file — UUID-named, sharded path (`/images/{shard}/{uuid}.ext`)
`Title`	Multi-language title entry with kind classification
`Person`	Artist/writer/etc. with display/sort names
`Circle`	Doujinshi circle/group
`Tag`	Category with normalizedName and optional namespace
`DoujinPerson`	Join: Doujin ↔ Person with role (composite key: DoujinId+PersonId+Role)
`DoujinCircle`	Join: Doujin ↔ Circle
`DoujinTag`	Join: Doujin ↔ Tag

Port: IIdGenerator interface (9 methods, one per ID type)

Infrastructure — EF Core Layer

DoujinManagerDbContext with 12 DbSet<> properties
12 IEntityTypeConfiguration<> classes with Fluent API mapping (no EF attributes in domain)
StronglyTypedIdConverterFactory — expression-tree-based ValueConverter<TId, Guid> and nullable variant
ModelBuilderExtensions — UseStronglyTypedId() helper for entities and nullable FKs
GuidIdGenerator — default IIdGenerator implementation
InitialCreate migration — 12 tables, 15 indexes, all FK constraints with cascade/restrict/set-null rules
EF Core SQLite + Design packages added to CPM
SQLitePCLRaw.bundle_e_sqlite3 3.0.0 pinned (fixes GHSA-2m69-gcr7-jv3q)

Server

DbContext registered with DOUJIN_MANAGER_DB_PATH env var (default: /app/data/doujin-manager.db)
IIdGenerator registered as singleton

Tests (23 total, all passing)

ApplicationCore.Tests (13 tests):

6 strongly typed ID tests (equality, uniqueness, type safety, IStronglyTypedId interface)
7 domain entity tests (defaults, flat/chaptered pages, ImageFile sharded paths, multi-variant doujins)

Infrastructure.Tests (8 tests, in-memory SQLite):

CRUD: Doujin with Variant + Titles
Variant with Chapters and Pages
Flat variant (null ChapterId)
Person with role on Doujin
Tag association
Cascade delete (Doujin → Variant → Page)
Strongly typed ID round-trip persistence

Verification

Check	Result
`dotnet build`	✅ 0 errors, 0 warnings
`dotnet test`	✅ 23/23 pass
`dotnet ef database update`	✅ Migration applies cleanly
`git diff --check`	✅ Clean

## Summary Implements the complete domain model, EF Core persistence layer, and initial database migration. ## What's included ### ApplicationCore — Domain Model **9 strongly typed IDs** (readonly record structs implementing `IStronglyTypedId`): - `DoujinId`, `VariantId`, `ChapterId`, `PageId`, `ImageFileId`, `TitleId`, `PersonId`, `CircleId`, `TagId` **4 enums:** - `TitleKind` (Original, Translated, Romaji, Alias) - `PersonRole` (Artist, Writer, Translator, Editor, Scanners, Other) - `VariantKind` (Original, Translated, Reedition, Other) - `ReadingDirection` (LeftToRight, RightToLeft) **12 domain entities:** | Entity | Description | |--------|-------------| | `Doujin` | Logical work — metadata, rating, reading direction, preferred display language | | `Variant` | Readable edition/language — has mandatory `LanguageCode`, independent page list | | `Chapter` | Optional ordered grouping within variant | | `Page` | Stable logical page — ID persists across image replacements; optional `ChapterId` | | `ImageFile` | Physical file — UUID-named, sharded path (`/images/{shard}/{uuid}.ext`) | | `Title` | Multi-language title entry with kind classification | | `Person` | Artist/writer/etc. with display/sort names | | `Circle` | Doujinshi circle/group | | `Tag` | Category with normalizedName and optional namespace | | `DoujinPerson` | Join: Doujin ↔ Person with role (composite key: DoujinId+PersonId+Role) | | `DoujinCircle` | Join: Doujin ↔ Circle | | `DoujinTag` | Join: Doujin ↔ Tag | **Port:** `IIdGenerator` interface (9 methods, one per ID type) ### Infrastructure — EF Core Layer - `DoujinManagerDbContext` with 12 `DbSet<>` properties - 12 `IEntityTypeConfiguration<>` classes with Fluent API mapping (no EF attributes in domain) - `StronglyTypedIdConverterFactory` — expression-tree-based `ValueConverter<TId, Guid>` and nullable variant - `ModelBuilderExtensions` — `UseStronglyTypedId()` helper for entities and nullable FKs - `GuidIdGenerator` — default `IIdGenerator` implementation - `InitialCreate` migration — 12 tables, 15 indexes, all FK constraints with cascade/restrict/set-null rules - EF Core SQLite + Design packages added to CPM - `SQLitePCLRaw.bundle_e_sqlite3` 3.0.0 pinned (fixes [GHSA-2m69-gcr7-jv3q](https://github.com/advisories/GHSA-2m69-gcr7-jv3q)) ### Server - `DbContext` registered with `DOUJIN_MANAGER_DB_PATH` env var (default: `/app/data/doujin-manager.db`) - `IIdGenerator` registered as singleton ### Tests (23 total, all passing) **ApplicationCore.Tests** (13 tests): - 6 strongly typed ID tests (equality, uniqueness, type safety, `IStronglyTypedId` interface) - 7 domain entity tests (defaults, flat/chaptered pages, ImageFile sharded paths, multi-variant doujins) **Infrastructure.Tests** (8 tests, in-memory SQLite): - CRUD: Doujin with Variant + Titles - Variant with Chapters and Pages - Flat variant (null ChapterId) - Person with role on Doujin - Tag association - Cascade delete (Doujin → Variant → Page) - Strongly typed ID round-trip persistence ## Verification | Check | Result | |-------|--------| | `dotnet build` | ✅ 0 errors, 0 warnings | | `dotnet test` | ✅ 23/23 pass | | `dotnet ef database update` | ✅ Migration applies cleanly | | `git diff --check` | ✅ Clean | ## Related ADRs - [ADR-0004: Domain Model](docs/adr/0004-domain-model-doujin-variant-page-image.md) - [ADR-0005: UUID IDs and Backend-Owned Image Storage](docs/adr/0005-uuid-ids-and-backend-owned-image-storage.md) - [ADR-0006: SQLite + EF Core Persistence](docs/adr/0006-sqlite-ef-core-persistence.md)

matikane added 1 commit

2026-06-27 23:28:27 +02:00

feat: domain model, EF Core DbContext, and initial migration 12c1f0823b

ApplicationCore:
- 9 strongly typed ID structs (DoujinId, VariantId, ChapterId, PageId,
  ImageFileId, TitleId, PersonId, CircleId, TagId) implementing IStronglyTypedId
- 4 enums (TitleKind, PersonRole, VariantKind, ReadingDirection)
- 12 domain entities (Doujin, Variant, Chapter, Page, ImageFile, Title,
  Person, Circle, Tag, DoujinPerson, DoujinCircle, DoujinTag)
- IIdGenerator port interface
- ImageFile computed properties (Shard, StoragePath, ThumbnailPath)

Infrastructure:
- DoujinManagerDbContext with 12 DbSets
- 12 IEntityTypeConfiguration classes with Fluent API mapping
- StronglyTypedIdConverterFactory for Guid↔TId value conversion
- ModelBuilderExtensions for UseStronglyTypedId helper
- GuidIdGenerator implementation of IIdGenerator
- InitialCreate migration (12 tables, 15 indexes, FK constraints)
- EF Core SQLite + Design packages added
- SQLitePCLRaw.bundle_e_sqlite3 3.0.0 pinned (fixes GHSA-2m69-gcr7-jv3q)

Server:
- DbContext registered with DOUJIN_MANAGER_DB_PATH env var
- IIdGenerator registered as singleton

Tests:
- 6 strongly typed ID unit tests
- 7 domain entity unit tests
- 7 DbContext integration tests (in-memory SQLite)
- All 23 tests pass, 0 warnings, migration applies cleanly

matikane commented

2026-06-28 08:59:22 +02:00

Author

Member

🤖 Hermes automated review: no blocking issues found

I reviewed the PR diff for correctness, security, data-loss risks, EF Core mapping/migration issues, and test coverage. I did not find blocking issues to request changes on.

Notes:

Static added-line security scan found no hardcoded secrets, shell injection, dangerous eval/exec, unsafe deserialization, or obvious SQL interpolation patterns.
Local dotnet build --no-restore could not be completed because project.assets.json files were not present in the checkout; I did not run restore/dependency installation in this cron job. Please rely on CI or run dotnet restore && dotnet build && dotnet test before merging.
This is not a formal Forgejo approval because the current MCP integration can only create PR conversation comments, not review approval states.

Automated daily review. I never merge PRs.

## 🤖 Hermes automated review: no blocking issues found I reviewed the PR diff for correctness, security, data-loss risks, EF Core mapping/migration issues, and test coverage. I did not find blocking issues to request changes on. Notes: - Static added-line security scan found no hardcoded secrets, shell injection, dangerous eval/exec, unsafe deserialization, or obvious SQL interpolation patterns. - Local `dotnet build --no-restore` could not be completed because `project.assets.json` files were not present in the checkout; I did not run restore/dependency installation in this cron job. Please rely on CI or run `dotnet restore && dotnet build && dotnet test` before merging. - This is not a formal Forgejo approval because the current MCP integration can only create PR conversation comments, not review approval states. Automated daily review. I never merge PRs.