fix: QScreen ImportError + GUI import smoke tests #2

Closed

matikane wants to merge 1 commit from fix/qscreen-import into main

matikane commented

2026-06-28 18:03:33 +02:00

Member

Fix: QScreen ImportError when clicking tray icon

The bug

QScreen was imported from PySide6.QtWidgets inside the _show_panel() method body, but QScreen lives in PySide6.QtGui. This caused an ImportError every time the tray icon was clicked.

Root cause

Inline imports in method bodies hide import errors from the test suite — they only trigger at runtime on specific code paths. The existing 36 tests all passed because none of them exercised the GUI import paths.

The fix

Moved QScreen and QCursor to module-level imports from the correct module (PySide6.QtGui)
Also hoisted QSvgRenderer from PySide6.QtSvg (was inline in _load_svg_icon)
Removed all inline from PySide6... import ... statements from method bodies

New tests: `test_gui_imports.py` (7 tests)

These tests exist specifically to prevent this class of bug:

Test	What it catches
`test_qtcore_imports_resolve`	Wrong-module imports from QtCore
`test_qtgui_imports_resolve`	Wrong-module imports from QtGui (would have caught QScreen)
`test_qtwidgets_imports_resolve`	Wrong-module imports from QtWidgets
`test_qtsvg_imports_resolve`	QtSvg import issues
`test_qscreen_not_in_qtwidgets`	Regression guard: QScreen must NOT be in QtWidgets
`test_main_module_imports_without_error`	Imports main.py and verifies no ImportError
`test_no_inline_imports_in_methods`	AST scan: no `from PySide6... import` inside method bodies

43 tests total, all passing.

You're right that this should have been caught — the GUI code had zero import coverage. These tests now guard every PySide6 symbol and enforce that imports are at module level where static analysis can see them.

## Fix: QScreen ImportError when clicking tray icon ### The bug `QScreen` was imported from `PySide6.QtWidgets` inside the `_show_panel()` method body, but `QScreen` lives in `PySide6.QtGui`. This caused an `ImportError` every time the tray icon was clicked. ### Root cause Inline imports in method bodies hide import errors from the test suite — they only trigger at runtime on specific code paths. The existing 36 tests all passed because none of them exercised the GUI import paths. ### The fix - Moved `QScreen` and `QCursor` to module-level imports from the correct module (`PySide6.QtGui`) - Also hoisted `QSvgRenderer` from `PySide6.QtSvg` (was inline in `_load_svg_icon`) - Removed all inline `from PySide6... import ...` statements from method bodies ### New tests: `test_gui_imports.py` (7 tests) These tests exist specifically to prevent this class of bug: | Test | What it catches | |---|---| | `test_qtcore_imports_resolve` | Wrong-module imports from QtCore | | `test_qtgui_imports_resolve` | Wrong-module imports from QtGui (would have caught QScreen) | | `test_qtwidgets_imports_resolve` | Wrong-module imports from QtWidgets | | `test_qtsvg_imports_resolve` | QtSvg import issues | | `test_qscreen_not_in_qtwidgets` | Regression guard: QScreen must NOT be in QtWidgets | | `test_main_module_imports_without_error` | Imports main.py and verifies no ImportError | | `test_no_inline_imports_in_methods` | AST scan: no `from PySide6... import` inside method bodies | **43 tests total, all passing.** You're right that this should have been caught — the GUI code had zero import coverage. These tests now guard every PySide6 symbol and enforce that imports are at module level where static analysis can see them.

matikane added 1 commit

2026-06-28 18:03:33 +02:00

fix: QScreen import error + add GUI import smoke tests

CI / test (pull_request) Failing after 14s

Details

3b42cff420

The bug: QScreen was imported from PySide6.QtWidgets inside the
_show_panel() method body, but QScreen lives in PySide6.QtGui.
This caused an ImportError when clicking the tray icon.

Root cause: inline imports in method bodies hide import errors from
the test suite — they only trigger at runtime on specific code paths.

Fix:
- Move QScreen and QCursor imports to module level (correct module: QtGui)
- Move QSvgRenderer import to module level (was inline in _load_svg_icon)
- Remove all inline PySide6 imports from method bodies

New tests (test_gui_imports.py, 7 tests):
- Verify every PySide6 symbol imported in main.py resolves correctly
- Verify QScreen is NOT importable from QtWidgets (regression guard)
- Verify main.py imports without error (catches all import bugs at once)
- AST-based test: no inline PySide6 imports in method bodies

43 tests total, all passing.

matikane referenced this pull request from a commit

2026-06-28 18:10:23 +02:00

fix: tray icons not loading + QScreen import + CI system deps

matikane referenced this pull request

2026-06-28 18:10:37 +02:00

fix: tray icons + QScreen import + CI system deps #3